Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Update sidekiq: 6.5.8 → 7.1.0 (major) #1424

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 2, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ sidekiq (6.5.8 → 7.1.0) · Repo · Changelog

Release Notes

7.1.0 (from changelog)

  • Improve display of ActiveJob arguments in Web UI [#5825, cover]
  • Update push_bulk to push batch_size jobs at a time and allow laziness [#5827, fatkodima] This allows Sidekiq::Client to push unlimited jobs as long as it has enough memory for the batch_size.
  • Update perform_bulk to use push_bulk internally.
  • Change return value of push_bulk to map 1-to-1 with arguments. If you call push_bulk(args: [[1], [2], [3]]), you will now always get an array of 3 values as the result: ["jid1", nil, "jid3"] where nil means that particular job did not push successfully (possibly due to middleware stopping it). Previously nil values were removed so it was impossible to tell which jobs pushed successfully and which did not.
  • Migrate away from all deprecated Redis commands [#5788] Sidekiq will now print a warning if you use one of those deprecated commands.
  • Prefix all Sidekiq thread names [#5872]

7.0.9 (from changelog)

  • Restore confirmation dialogs in Web UI [#5881, shevaun]
  • Increase fetch timeout to minimize ReadTimeoutError [#5874]
  • Reverse histogram tooltip ordering [#5868]
  • Add Scottish Gaelic (gd) locale [#5867, GunChleoc]

7.0.7 (from changelog)

  • Fix redis-client API usage which could result in stuck Redis connections [#5823]
  • Fix AS::Duration with sidekiq_retry_in [#5806]
  • Restore dumping config options on startup with -v [#5822]

7.0.5 (from changelog)

  • More context for debugging json unsafe errors [#5787]

7.0.4 (from changelog)

  • Performance and memory optimizations [#5768, fatkodima]
  • Add 1-8 hour period selector to Metrics pages [#5694]
  • Fix process display with sidekiqmon [#5733]

7.0.3 (from changelog)

  • Don't warn about memory policy on Redis Enterprise [#5712]
  • Don't allow Quiet/Stop on embedded Sidekiq instances [#5716]
  • Fix size: X for configuring the default Redis pool size [#5702]
  • Improve the display of queue weights on Busy page [#5642]
  • Freeze CurrentAttributes on a job once initially set [#5692]

7.0.2 (from changelog)

  • Improve compatibility with custom loggers [#5673]
  • Add queue weights on Busy page [#5640]
  • Add BID link on job_info page if job is part of a Batch [#5623]
  • Allow custom extensions to add rows/links within Job detail pages [#5624]
Sidekiq::Web.custom_job_info_rows << AddAccountLink.new

class AddAccountLink
include CGI::Util
def add_pair(job)
# yield a (name, value) pair
# You can include HTML tags and CSS, Sidekiq does not do any
# escaping so beware user data injection! Note how we use CGI's
# h escape helper.
aid = job["account_id"]
yield "Account", "<a href='/accounts/#{h aid}'>#{h aid}</a>" if aid
end
end

7.0.1 (from changelog)

  • Allow an embedding process to reuse its own heartbeat thread
  • Update zh-cn localization

7.0.0 (from changelog)

  • Embedded mode!
  • Capsules!!
  • Job Execution metrics!!!
  • See docs/7.0-Upgrade.md for release notes

6-x

  • Add pagination to Busy page [#5556]
  • Speed up WorkSet#each [#5559]
  • Adjust CurrentAttributes to work with the String class name so we aren't referencing the Class within a Rails initializer [#5536]

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ connection_pool (indirect, 2.3.0 → 2.4.0) · Repo · Changelog

Release Notes

2.4.0 (from changelog)

  • Automatically drop all connections after fork [#166]

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 4 commits:

↗️ rack (indirect, 2.2.6.4 → 2.2.7) · Repo · Changelog

Release Notes

2.2.7

What's Changed

New Contributors

Full Changelog: v2.2.6.4...v2.2.7

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 3 commits:

🆕 redis-client (added, 0.14.1)

🗑️ redis (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Sep 16, 2023

Closed in favor of #1436.

@depfu depfu bot closed this Sep 16, 2023
@depfu depfu bot deleted the depfu/update/sidekiq-7.1.0 branch September 16, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant