Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-403 #404

Merged
merged 21 commits into from
Sep 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1767bc4
WIP. Adding a new field: type to display or hidesome fields
cmoulliard May 12, 2023
cbcff11
WIP. Add a note to specify that a new test case is needed. #403
cmoulliard Sep 25, 2023
f78ad26
Add a new JS function able to collapse (or not) the fields according …
cmoulliard Sep 26, 2023
8461247
Adding the missing new parameter credential_type
cmoulliard Sep 26, 2023
61694ab
Adding the missing field: credentialType to the createCredential method
cmoulliard Sep 26, 2023
a3a3cb8
Format the code
cmoulliard Sep 27, 2023
d1d9f41
Passing the needed parameter: credentialType to the createCredential …
cmoulliard Sep 27, 2023
7ef275e
Adding the missing credential_type to the HTML Page test
cmoulliard Sep 27, 2023
480ca8e
Adding the missing trailing ;
cmoulliard Sep 27, 2023
c0e0d52
Reformating the java code
cmoulliard Sep 27, 2023
bd82908
Changing the action from type to select as this is a popup list
cmoulliard Sep 27, 2023
3b6e986
Creating 2 test cases able to test according to the type: basic or vault
cmoulliard Sep 27, 2023
12d6a1f
Copy the request.type to the credential.type
cmoulliard Sep 27, 2023
cfc1f25
Renaming the method to testCreateUserPasswordCredential as more meani…
cmoulliard Sep 27, 2023
c99074a
Renaming the wrong HTML name from serviceID to type
cmoulliard Sep 27, 2023
2cfa605
Fix wrong form name for the credential type
cmoulliard Sep 27, 2023
4f0a4f4
Reformat the code
cmoulliard Sep 27, 2023
238387f
Include also the Vault Path part of the table displayed
cmoulliard Sep 27, 2023
1d64fb1
Changing the name of the service
cmoulliard Sep 27, 2023
7bc00c0
Changing the name of the credential for vault test to credential2 and…
cmoulliard Sep 27, 2023
6701ff8
Adding the missing parameter: credential_type
cmoulliard Sep 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format the code
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
  • Loading branch information
cmoulliard authored and aureamunoz committed Sep 27, 2023
commit a3a3cb8b03deebd0984391a4f89b430d6f0875c7
10 changes: 5 additions & 5 deletions app/src/test/java/io/halkyon/utils/TestUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ public static Application createApplication(String applicationName, String clust
return app;
}

public static Credential createCredential(String credentialName, String credentialType, long serviceId, String username, String password,
String vaultPath) {
public static Credential createCredential(String credentialName, String credentialType, long serviceId,
String username, String password, String vaultPath) {
given().contentType(MediaType.APPLICATION_FORM_URLENCODED).formParam("name", credentialName)
.formParam("credentialType",credentialType)
.formParam("serviceId", serviceId).formParam("username", username).formParam("password", password)
.formParam("vaultKvPath", vaultPath).when().post("/credentials").then().statusCode(201);
.formParam("credentialType", credentialType).formParam("serviceId", serviceId)
.formParam("username", username).formParam("password", password).formParam("vaultKvPath", vaultPath)
.when().post("/credentials").then().statusCode(201);

return given().contentType(MediaType.APPLICATION_JSON).get("/credentials/name/" + credentialName).then()
.statusCode(200).extract().as(Credential.class);
Expand Down