use addOpener and uri for sidekick dock implementation (this is just a hint) #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've implemented the Dock in elm-navigator, so I thought I'd have a go at putting the Sidekick in a dock. I noticed you'd already made a branch for this though. When I tried running it locally, I couldn't get the Dock to open - it seemed there were a couple of things missing, so I had a quick go at adding the missing pieces.
This PR is really messy and unfinished as I merged master while adding the dock at the same time. It does actually work though if you load it in Atom. If you toggle the sidekick from the menu, you should see the sidekick in a Dock.
The important parts are here:
https://github.com/halohalospecial/atom-elmjutsu/compare/master...mbylstra:sidekick-dock-more-progress?expand=1#diff-10fea451bc70b3b775a852e7cea23804R74
https://github.com/halohalospecial/atom-elmjutsu/compare/master...mbylstra:sidekick-dock-more-progress?expand=1#diff-bf2b827aa6d4d64656848a48f6c57d80L86
https://github.com/halohalospecial/atom-elmjutsu/compare/master...mbylstra:sidekick-dock-more-progress?expand=1#diff-16b7d75b70953cbf4755508170f2f24cR107
You'd probably just want to continue from your own branch and discard this PR. I just put it here for a reference in case you were stuck. I commented most of the toggleCommand function, as I didn't quite know how to integrate the configuration stuff. This is an example I've been going on (as the official docs are a bit light on Docks): https://github.com/atom/active-editor-info. Perhaps it was already working and the uri stuff wasn't necessary... I'm not sure! In any case, I think the uri stuff is necessary for the dock to persist when the user re-opens Atom.