Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove legacy bash scripts #370

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

roleyfoley
Copy link
Contributor

Intent of Change

  • Refactor (non-breaking change which improves the structure or operation of the implementation)

Description

  • Removes all automation bash scripts as they are no longer supported and have been replaced with other processes
  • Moves the saveCMDBRepos script into the execution side of the bash scripts as it is still in use
  • Removes any execution scripts that are no longer support and have been replaced with other commands

Motivation and Context

This is pretty much the final stage into deprecating direct access to the hamlet bash engine. The cli is feature complete with what was in these scripts now and anything that is required for specific cases should be added as runbooks if they are no longer supported directly in hamlet.

How Has This Been Tested?

Tested locally

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

@roleyfoley roleyfoley requested a review from a team September 28, 2023 06:39
@ml019
Copy link
Contributor

ml019 commented Sep 28, 2023

@roleyfoley thinking you'll know what the issue is?

- Removes all automation bash scripts as they are no longer supported
and have been replaced with other processes
- Moves the saveCMDBRepos script into the execution side of the bash
scripts as it is still in use
- Removes any execution scripts that are no longer support and
have been replaced with other commands
@roleyfoley roleyfoley force-pushed the refactor/remove-legacy-bash-scripts branch from d0eecac to 2447514 Compare September 28, 2023 10:36
@roleyfoley roleyfoley merged commit 020dae3 into master Sep 28, 2023
1 check passed
@roleyfoley roleyfoley deleted the refactor/remove-legacy-bash-scripts branch September 28, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants