Improve partial indenting performance #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohd-akram
force-pushed
the
perf-indent
branch
from
a645964
to
e94c228
Compare
mohd-akram
force-pushed
the
perf-indent
branch
from
e94c228
to
ad65a01
Compare
jaylinski
approved these changes
Sep 4, 2023
|
@jaylinski has any schedule to release this issue? It seems that we meet the same problem. |
|
Will probably have to revert this. Testing some more, this causes some excessive GC activity which actually makes things slower in some cases. EDIT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about 30% faster in my testing.
Related to #1991.