Add support for Multi-Factor Authentication Every Sign In setting #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds methods for saving and loading a session, to avoid having to authenticate each time the API is used in a new execution, kernel instance, etc. Both the session cookies and CSRF token are stored to a file via Python's bulit-in pickling. Both methods take a file name param, to define where the data should be written or read.
Bugfixes to handle changes to Personal Capital CSRF token parsing
|
Since it’s been a while, I’ll wait another month for the review.
If nothing comes to pass, my fork of the repo has my change, happy to take
more, and I can put a new library into PyPI. Not ideal, I know, but it will
unblock folks.
…On Tue, Nov 28, 2023 at 13:07 KL4RKS ***@***.***> wrote:
@haochi <https://github.com/haochi>, It'd be nice if #24
<#24> (by @hammem
<https://github.com/hammem>) and this could be merged and a new version
of personalcapital be pushed to be used with pip
<https://pypi.org/project/personalcapital/>. With Mint is shutting down
these updates could help others shifting to use personal capital data like
myself.
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAICHMTL4G6XPSI77CF3LHLYGYR67AVCNFSM6AAAAAA76FJICWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGQYDSOBQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
seems like this library is abandoned, it might be a good idea to upload a new library and build from there |
|
I think that tne new package name should contain the words Personal Capital to make it easier to find via search. How about |
|
Has the pypi been created? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes (and requires) commits from PR #24