Add timezone based validate and manipulation of period start and end to $evaluate-measure #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukedegruchy
commented
Sep 27, 2024
•
lukedegruchy
commented
- Introduce new request header: Timestamp
- Introduce MeasureReportPeriodConversionHandler, which validates inputs for period start and end, and converts to timestamps with offset based on the request header timezone or the fallback timezone of UTC if no Timestamp header is provided
- Inject this into the $evaluate-measure MeasureOperationsProvider, but do not invoke it yet. This will be dead code dependent on future changes.
- Introduce CrBaseConfig for config shared between DSTU3 and R4, and add the class above to that config
- New tests
- Fix existing tests based on the new behaviour above
…on logic to $evaluate-measure.
…e some existing tests and address TODOs.
…th start and end as null or both neither. javadoc. Refactoring. More tests.
|
Formatting check succeeded! |
…ing config class to be used by both DSTU3 and R4.
…e-measure-timezone
lukedegruchy
changed the title
lukedegruchy
force-pushed
the
ld-20240919-evaluate-measure-timezone
branch
from
913e84a
to
3af223f
Compare
barhodes
approved these changes
Sep 27, 2024
… Strings. Leave this code dormant for now. Fix and change tests. Add serialization and deserialization code for JSON Parameters.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6328 +/- ##
============================================
- Coverage 83.54% 83.53% -0.01%
- Complexity 27432 27657 +225
============================================
Files 1707 1722 +15
Lines 106185 107037 +852
Branches 13397 13463 +66
============================================
+ Hits 88710 89416 +706
- Misses 11750 11840 +90
- Partials 5725 5781 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Capt-Mac
reviewed
Oct 1, 2024
| * Either both must be null or neither. | ||
| */ | ||
| public class MeasurePeriodForEvaluation { | ||
| @Nullable |
There was a problem hiding this comment.
suggestion: we push this into Clinical-reasoning instead of hapi-fhir as this can be upstreamed validation
Capt-Mac
approved these changes
Oct 1, 2024
|
Superseded by: #6358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.