Fix Postgres migration when schema is not public. #6340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6339
If the schema being used for HAPI in Postgres is not the
public
schema, the 7.4.0 migrations fails because the newDeletePrimaryKeyTask
assumes the active schema ispublic
when it looks up the primary key name.This changes it to use
current_schema()
if available (i.e. the HAPI user has a search_path set) and'public'
otherwise.Tested by running the 7.4.2 migrations with this change incorporated against a database where the old migrations were failing.