Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction to #6341 #6342

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Correction to #6341 #6342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/util/MemoryCacheService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private void populateCaches() {
case CONCEPT_TRANSLATION_REVERSE:
timeoutSeconds =
SECONDS.convert(myStorageSettings.getTranslationCachesExpireAfterWriteInMinutes(), MINUTES);
maximumSize = 10000;
maximumSize = 500000;
break;
case PID_TO_FORCED_ID:
case FORCED_ID_TO_PID:
Expand Down Expand Up @@ -200,6 +200,12 @@ public enum CacheEnum {
* Value type: {@literal Optional<String>}
*/
PID_TO_FORCED_ID(Long.class),
/**
* TODO: JA this is duplicate with the CachingValidationSupport cache.
* A better solution would be to drop this cache for this item, and to
* create a new CachingValidationSupport implementation which uses
* the MemoryCacheService for all of its caches.
*/
CONCEPT_TRANSLATION(TranslationQuery.class),
MATCH_URL(String.class),
CONCEPT_TRANSLATION_REVERSE(TranslationQuery.class),
Expand Down
2 changes: 1 addition & 1 deletion ...n/src/main/java/org/hl7/fhir/common/hapi/validation/support/CachingValidationSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public CachingValidationSupport(
myExpandValueSetCache = CacheFactory.build(theCacheTimeouts.getExpandValueSetMillis(), 100);
myValidateCodeCache = CacheFactory.build(theCacheTimeouts.getValidateCodeMillis(), 5000);
myLookupCodeCache = CacheFactory.build(theCacheTimeouts.getLookupCodeMillis(), 5000);
myTranslateCodeCache = CacheFactory.build(theCacheTimeouts.getTranslateCodeMillis(), 500000);
myTranslateCodeCache = CacheFactory.build(theCacheTimeouts.getTranslateCodeMillis(), 5000);
myCache = CacheFactory.build(theCacheTimeouts.getMiscMillis(), 5000);
myNonExpiringCache = Collections.synchronizedMap(new HashMap<>());

Expand Down
Loading