Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing SearchParameter validation #6616

Closed
wants to merge 8 commits into from
Closed

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Jan 13, 2025

closes #6615

Copy link

github-actions bot commented Jan 13, 2025

Formatting check succeeded!

… of LogbackTestExtension to validate that it really skipped the validation logic.
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (46d5809) to head (41c5816).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6616   +/-   ##
=========================================
  Coverage     83.50%   83.51%           
- Complexity    28566    28569    +3     
=========================================
  Files          1797     1797           
  Lines        111166   111173    +7     
  Branches      13965    13968    +3     
=========================================
+ Hits          92828    92842   +14     
+ Misses        12351    12343    -8     
- Partials       5987     5988    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JasonRoberts-smile JasonRoberts-smile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating search parameters with 'skip_validation' does not skip validation
3 participants