Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deadlock in subscription registry #6632

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

Copy link

Formatting check succeeded!

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you moved the synchronizing over into the map, and removed synchronization on the cache itself? I don't understand why this fixes it, but I assume you do!

Copy link
Collaborator

@fil512 fil512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tadgh tadgh enabled auto-merge (squash) January 17, 2025 20:35
@tadgh tadgh disabled auto-merge January 17, 2025 20:37
@tadgh tadgh merged commit 15c792b into master Jan 17, 2025
121 of 123 checks passed
@tadgh tadgh deleted the ja_20250117_resolve_deadlock branch January 17, 2025 20:37
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (406db33) to head (5b9d24f).
Report is 169 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6632      +/-   ##
============================================
- Coverage     83.54%   83.50%   -0.04%     
- Complexity    27432    28564    +1132     
============================================
  Files          1707     1797      +90     
  Lines        106185   111161    +4976     
  Branches      13397    13965     +568     
============================================
+ Hits          88710    92826    +4116     
- Misses        11750    12346     +596     
- Partials       5725     5989     +264     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants