Fixing concurrent modification problem in VersionSpecificContextWrapper #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added test shows the issue with VersionSpecificWorkerContextWrapper#allStructureDefinitions() where resources are returned more than once.
Snapshotted StructureDefinitions are now added to a new list, instead of to the list of non-snapshotted StructureDefinitions. This not only leads to the resource being in the list twice, but also leads to ConcurrentModificationExceptions when iterating over the result of allStructureDefinitions(). Fixes hapifhir#6661
Boereck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #6661. The test case added only checks the synchronous error case.
The concurrency issue could be tested, but not deterministically. And on my machine this
needs many iterations to trigger the problem. On my machine it takes around 5 seconds
to trigger the issue.