Log full stack trace on validator exceptions #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be difficult to debug the root cause of exceptions in the validator wrapper because only the exception message is returned and logged, not the whole stack trace. This PR just adds the caught exception to the logger statement so that the stack trace is logged. No changes to the response.
Addresses the most important part of #170 (and the previous PR #168 also made uncaught Errors get logged, so that's no longer a big concern either)
I haven't been able to consistently reproduce Exceptions (the ones we've seen have been one-off or environment related), so the easiest way to test this is probably to change the method
ValidationControllerImpl.validateRequest
to just throw an exception, eg:Before this PR change, this would log:
With the PR change: