Use gson for serialization/deserialization #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehall
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Tested locally and looks good to me, thanks! The UI works and I confirmed our large file works as well. (the UI times out after 2 minutes as noted elsewhere but the validation process completed behind the scenes)
Sorry this required that change over on the core side, hopefully that was quick to implement
|
@dehall IntelliJ IDEA has a feature called Structural Search which lets you create searches that have access to Java structures. It's a little finicky to use, but in cases like this (finding all fields and methods annotated with Jackson), it works really well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches content negotiation from jackson to gson.
This will require core to be updated before this can be merged, with this PR: hapifhir/org.hl7.fhir.core#1824