Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of registered ERC20 tokens to bank send method on SDK layer #252

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

Yurist-85
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@Yurist-85 Yurist-85 requested review from onsails and kioqq November 14, 2023 17:12
@kioqq kioqq force-pushed the feat-bank-send-erc20 branch from 808a22c to 8f9f5d8 Compare November 28, 2023 13:44
@kioqq kioqq requested a review from VorobevSA November 28, 2023 14:04
Copy link

@VorobevSA VorobevSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok, need testing on fork

@kodiakhq kodiakhq bot merged commit 4f36090 into master Dec 1, 2023
14 checks passed
@kodiakhq kodiakhq bot deleted the feat-bank-send-erc20 branch December 1, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants