Skip to content

Commit

Permalink
Fix error when @salesforce/cli has been installed with nvm
Browse files Browse the repository at this point in the history
  • Loading branch information
nvuillam committed Aug 18, 2023
1 parent 389ba71 commit 775dd0b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

## [Unreleased]

## [1.34.0] 2023-07-22
## [2.0.0] 2023-08-18

- Automatically uninstall sfdx-cli then install @salesforce/cli to follow [Salesforce recommendations]([Title](https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_move_to_sf_v2.htm))
- Fix false positive error when nvm has been used to install @salesforce/cli (thanks @anthonygiuliano :))

## [1.33.1] 2023-07-10

Expand Down
1 change: 1 addition & 0 deletions src/hardis-plugins-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ export class HardisPluginsProvider
} else if (
!sfdxPath.includes("npm") &&
!sfdxPath.includes("nodejs") &&
!sfdxPath.includes("nvm") &&
sfdxPath !== "missing"
) {
sfdxCliItem.label = sfdxCliItem.label + " (WRONGLY INSTALLED)";
Expand Down

0 comments on commit 775dd0b

Please sign in to comment.