Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AH-758]: Onboard Harness Artifact Registry #614

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

ritek01
Copy link
Member

@ritek01 ritek01 commented Dec 6, 2024

Describe your changes

Onboarded Harness Artifact Registry Api to GO-SDK for Onboarding of Terraform.
https://apidocs.harness.io/tag/Registries

Terraform Provider Pr : harness/terraform-provider-harness#1146

Comment Triggers

PR Check triggers
  • Build: trigger build
  • gitleaks: trigger gitleaks

@ritek01 ritek01 marked this pull request as ready for review January 8, 2025 19:45
@ritek01
Copy link
Member Author

ritek01 commented Jan 8, 2025

Using new api Locally is working.
image

@shivamnegi94
Copy link
Contributor

are all the doc files added are required ?

@shivamnegi94
Copy link
Contributor

Usually we keep all the files inside the package https://github.com/harness/harness-go-sdk/tree/main/harness/nextgen
any reason we are not keeping on the same place ?

@ritek01
Copy link
Member Author

ritek01 commented Jan 10, 2025

Usually we keep all the files inside the package https://github.com/harness/harness-go-sdk/tree/main/harness/nextgen any reason we are not keeping on the same place ?

The new module is in a separate folder to make maintenance easier and to avoid messing with the existing package. I have followed same approach that was done for DBDevOps and Code modules, so this keeps things clean and organized without risking issues with what's already there.

@ritek01 ritek01 merged commit 5ce9d0f into main Jan 10, 2025
3 checks passed
@ritek01 ritek01 deleted the ritek/AH-758 branch January 10, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants