Skip to content

Commit

Permalink
feat:[CCM-20085]: Add Governance as feature in all cloud provider CCM…
Browse files Browse the repository at this point in the history
… connectors (#1110)

* feat:[CCM-20085]: Add Governance as feature in azure and gcp connector

* feat:[CCM-20085]: Add Governance as feature in aws connector
  • Loading branch information
iamanmolm authored Nov 6, 2024
1 parent 8074bc4 commit 182514c
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 21 deletions.
5 changes: 5 additions & 0 deletions .changelog/1091.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
```release-note:enhancement
harness_platform_connector_awscc: Added GOVERNANCE as a feature that can be enabled for the AWS Cloud Cost connector.
harness_platform_connector_azure_cloud_cost: Added GOVERNANCE as a feature that can be enabled for the Azure Cloud Cost connector.
harness_platform_connector_gcp_cloud_cost: Added GOVERNANCE as a feature that can be enabled for the GCP Cloud Cost connector.
```
4 changes: 1 addition & 3 deletions docs/data-sources/platform_connector_awscc.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ data "harness_platform_connector_awscc" "example" {
- `account_id` (String) The AWS account id.
- `cross_account_access` (List of Object) Harness uses the secure cross-account role to access your AWS account. The role includes a restricted policy to access the cost and usage reports and resources for the sole purpose of cost analysis and cost optimization. (see [below for nested schema](#nestedatt--cross_account_access))
- `description` (String) Description of the resource.
- `features_enabled` (Set of String) The features enabled for the connector. Valid values are BILLING, OPTIMIZATION, VISIBILITY.
- `features_enabled` (Set of String) The features enabled for the connector. Valid values are BILLING, OPTIMIZATION, VISIBILITY, GOVERNANCE.
- `id` (String) The ID of this resource.
- `report_name` (String) The cost and usage report name. Provided in the delivery options when the template is opened in the AWS console.
- `s3_bucket` (String) The name of s3 bucket.
Expand All @@ -49,5 +49,3 @@ Read-Only:

- `external_id` (String)
- `role_arn` (String)


4 changes: 1 addition & 3 deletions docs/data-sources/platform_connector_azure_cloud_cost.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ data "harness_platform_connector_azure_cloud_cost" "example" {

- `billing_export_spec` (List of Object) Returns billing details for the Azure account. (see [below for nested schema](#nestedatt--billing_export_spec))
- `description` (String) Description of the resource.
- `features_enabled` (Set of String) Indicates which feature to enable among Billing, Optimization, and Visibility.
- `features_enabled` (Set of String) Indicates which feature to enable among Billing, Optimization, Visibility and Governance.
- `id` (String) The ID of this resource.
- `subscription_id` (String) Subsription id.
- `tags` (Set of String) Tags to associate with the resource.
Expand All @@ -51,5 +51,3 @@ Read-Only:
- `report_name` (String)
- `storage_account_name` (String)
- `subscription_id` (String)


4 changes: 1 addition & 3 deletions docs/data-sources/platform_connector_gcp_cloud_cost.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ data "harness_platform_connector_gcp_cloud_cost" "example" {

- `billing_export_spec` (List of Object) Returns billing details. (see [below for nested schema](#nestedatt--billing_export_spec))
- `description` (String) Description of the resource.
- `features_enabled` (Set of String) Indicates which features to enable among Billing, Optimization, and Visibility.
- `features_enabled` (Set of String) Indicates which features to enable among Billing, Optimization, Visibility and Governance.
- `gcp_project_id` (String) GCP Project Id.
- `id` (String) The ID of this resource.
- `service_account_email` (String) Email corresponding to the Service Account.
Expand All @@ -48,5 +48,3 @@ Read-Only:

- `data_set_id` (String)
- `table_id` (String)


6 changes: 3 additions & 3 deletions docs/resources/platform_connector_awscc.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@ resource "harness_platform_connector_awscc" "test" {

- `account_id` (String) The AWS account id.
- `cross_account_access` (Block List, Min: 1, Max: 1) Harness uses the secure cross-account role to access your AWS account. The role includes a restricted policy to access the cost and usage reports and resources for the sole purpose of cost analysis and cost optimization. (see [below for nested schema](#nestedblock--cross_account_access))
- `features_enabled` (Set of String) The features enabled for the connector. Valid values are BILLING, OPTIMIZATION, VISIBILITY.
- `features_enabled` (Set of String) The features enabled for the connector. Valid values are BILLING, OPTIMIZATION, VISIBILITY, GOVERNANCE.
- `identifier` (String) Unique identifier of the resource.
- `name` (String) Name of the resource.

### Optional

- `report_name` (String) The cost and usage report name. Provided in the delivery options when the template is opened in the AWS console.
- `s3_bucket` (String) The name of s3 bucket.
- `description` (String) Description of the resource.
- `org_id` (String) Unique identifier of the organization.
- `project_id` (String) Unique identifier of the project.
- `report_name` (String) The cost and usage report name. Provided in the delivery options when the template is opened in the AWS console.
- `s3_bucket` (String) The name of s3 bucket.
- `tags` (Set of String) Tags to associate with the resource.

### Read-Only
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/platform_connector_azure_cloud_cost.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ resource "harness_platform_connector_azure_cloud_cost" "example" {
description = "example"
tags = ["foo:bar"]
features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION"]
features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION", "GOVERNANCE"]
tenant_id = "tenant_id"
subscription_id = "subscription_id"
billing_export_spec {
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/platform_connector_gcp_cloud_cost.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ resource "harness_platform_connector_gcp_cloud_cost" "test" {
description = "test"
tags = ["foo:bar"]
features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION"]
features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION", "GOVERNANCE"]
gcp_project_id = "gcp_project_id"
service_account_email = "service_account_email"
billing_export_spec {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resource "harness_platform_connector_azure_cloud_cost" "example" {
description = "example"
tags = ["foo:bar"]

features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION"]
features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION", "GOVERNANCE"]
tenant_id = "tenant_id"
subscription_id = "subscription_id"
billing_export_spec {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resource "harness_platform_connector_gcp_cloud_cost" "test" {
description = "test"
tags = ["foo:bar"]

features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION"]
features_enabled = ["BILLING", "VISIBILITY", "OPTIMIZATION", "GOVERNANCE"]
gcp_project_id = "gcp_project_id"
service_account_email = "service_account_email"
billing_export_spec {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/antihax/optional v1.0.0
github.com/aws/aws-sdk-go v1.46.4
github.com/docker/docker v24.0.5+incompatible
github.com/harness/harness-go-sdk v0.4.12
github.com/harness/harness-go-sdk v0.4.14
github.com/harness/harness-openapi-go-client v0.0.21
github.com/hashicorp/go-cleanhttp v0.5.2
github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMyw
github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/harness/harness-go-sdk v0.4.12 h1:NGNf8KqGOwVxrcAwzGuk6c1cJOSdxiW2JFoR7wULUZs=
github.com/harness/harness-go-sdk v0.4.12/go.mod h1:CPXydorp4zd5Dz2u2FXiHyWL4yd5PQafOMN69cgPSvk=
github.com/harness/harness-go-sdk v0.4.14 h1:P6UhTnCCGbO08ksv9Njg+dD3UspZDQ0gYonTyGjB/cw=
github.com/harness/harness-go-sdk v0.4.14/go.mod h1:CPXydorp4zd5Dz2u2FXiHyWL4yd5PQafOMN69cgPSvk=
github.com/harness/harness-openapi-go-client v0.0.21 h1:VtJnpQKZvCAlaCmUPbNR69OT3c5WRdhNN5TOgUwtwZ4=
github.com/harness/harness-openapi-go-client v0.0.21/go.mod h1:u0vqYb994BJGotmEwJevF4L3BNAdU9i8ui2d22gmLPA=
github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ func DataSourceConnectorAzureCloudCost() *schema.Resource {

Schema: map[string]*schema.Schema{
"features_enabled": {
Description: "Indicates which feature to enable among Billing, Optimization, and Visibility.",
Description: "Indicates which feature to enable among Billing, Optimization, Visibility and Governance.",
Type: schema.TypeSet,
Computed: true,
Elem: &schema.Schema{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ func DataSourceConnectorGCPCloudCost() *schema.Resource {

Schema: map[string]*schema.Schema{
"features_enabled": {
Description: "Indicates which features to enable among Billing, Optimization, and Visibility.",
Description: "Indicates which features to enable among Billing, Optimization, Visibility and Governance.",
Type: schema.TypeSet,
Computed: true,
Elem: &schema.Schema{
Expand Down

0 comments on commit 182514c

Please sign in to comment.