Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new register to the protocol called
UID
.Motivation
We currently use a single U16 value to keep track of the serial numbers of devices. This is a rather small number and hardly future proof. Adhering on a pre-existing standard would make the implementation much more generic. For instance, it would allow one to co-opt pico's chip serial number (64bit) into this register.
Detailed Design
For the sake of backward compatibility, we will add a new register instead of modifying the current
R_Serial_Number
.A new register will be added with the following specs:
Name: UID
Address: 16
Format: U8[16]
Access: Read-only
A deprecation warning was also added to the protocol regarding register
R_SERIAL_NUMBER
. For now, this register will duplicate the first two bytes ofR_UID
. On the next major release, theR_SERIAL_NUMBER
will likely be removed and onlyR_UID
supported.Design Meetings
See further discussion in the following issues: