Add hearbeat register #45
Open
+65
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-f-cruz
requested review from
Poofjunior,
glopesdev,
artursilva0 and
filcarv
|
+1 on this! This would be hugely useful, and head off a lot of data quality issues. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new register to the protocol called
HEARTBEAT.Motivation
We want to be able to periodically check the status of the device. Including synchronization, mode and error status.
Detailed Design
We will add a new register with the following specs:
Name: Heartbeat
Address: 18
Format: U16
Access: Read-only
For now, only 3 bits will be implemented:
The other 13 bits will remain free for future status bits.
More information is available in the PR.
Design Meetings
See further discussion in the following issues: