[warnings] fix warnings from new clang version

harrand · Dec 3, 2024 · c456b64 · c456b64
1 parent 1497ffa
commit c456b64
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/cmake/compiler.cmake b/cmake/compiler.cmake
@@ -22,7 +22,7 @@ endfunction()
 function(configure_gnu_like)
 	# GNU-like compiler. i.e gcc + clang, but not msvc or clang-cl.
 	# TODO	
-	target_compile_options(topaz PRIVATE -Wall -Wextra -Werror -pedantic-errors)
+	target_compile_options(topaz PRIVATE -Wall -Wextra -Werror -pedantic-errors -Wno-missing-field-initializers)
 endfunction()
 
 function(configure_clang)

diff --git a/include/tz/core/error.hpp b/include/tz/core/error.hpp
@@ -1,6 +1,7 @@
 #ifndef TOPAZ_CORE_ERROR_HPP
 #define TOPAZ_CORE_ERROR_HPP
 #include <string_view>
+#include <string>
 #include <array>
 
 namespace tz
@@ -64,4 +65,4 @@ namespace tz
 
 }
 
-#endif // TOPAZ_CORE_ERROR_HPP
+#endif // TOPAZ_CORE_ERROR_HPP
diff --git a/src/tz/core/lua.cpp b/src/tz/core/lua.cpp
@@ -98,7 +98,8 @@ namespace tz
 
 	tz::error_code lua_define_function(std::string_view varname, lua_fn fn)
 	{
-		lua_pushcfunction(lua, reinterpret_cast<lua_CFunction>(fn));
+		// note: this is undefined behaviour
+		lua_pushcfunction(lua, reinterpret_cast<lua_CFunction>(reinterpret_cast<std::uintptr_t>(fn)));
 		std::string tmp = std::format("tmp_{}", varname);
 		lua_setglobal(lua, tmp.c_str());
 		lua_execute(std::format("{} = {}", varname, tmp));
@@ -254,4 +255,4 @@ namespace tz
 		}
 		return type;
 	}
-}
+}