Skip to content

Commit

Permalink
Update variable name for java ecr build (aws-observability#256)
Browse files Browse the repository at this point in the history
*Issue description:*
Issue with the PR

*Description of changes:*
Updated ECR URI to point to the correct URI

*Rollback procedure:*
Revert

*Test Run:*

https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/11058416897

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
harrryr authored Sep 26, 2024
1 parent d50fe77 commit 9aac8e9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/java-sample-app-ecr-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Build and Upload Main Service Image
working-directory: sample-apps/java/springboot-main-service
run: |
sed -i 's#"{{ECR_IMAGE_URI}}"#"${{ env.E2E_TEST_ACCOUNT_ID }}.dkr.ecr.us-east-1.amazonaws.com/${{ env.JAVA_MAIN_SAMPLE_APP_IMAGE }}:v11"#g' build.gradle.kts
sed -i 's#"{{ECR_IMAGE_URI}}"#"${{ env.ACCOUNT_ID }}.dkr.ecr.${{ matrix.aws-region }}.amazonaws.com/${{ env.JAVA_MAIN_SAMPLE_APP_IMAGE }}:v11"#g' build.gradle.kts
gradle jib -P javaVersion=11
java-v11-remote:
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
- name: Build and Upload Remote Service Image
working-directory: sample-apps/java/springboot-remote-service
run: |
sed -i 's#"{{ECR_IMAGE_URI}}"#"${{ env.E2E_TEST_ACCOUNT_ID }}.dkr.ecr.us-east-1.amazonaws.com/${{ env.JAVA_REMOTE_SAMPLE_APP_IMAGE }}:v11"#g' build.gradle.kts
sed -i 's#"{{ECR_IMAGE_URI}}"#"${{ env.ACCOUNT_ID }}.dkr.ecr.${{ matrix.aws-region }}.amazonaws.com/${{ env.JAVA_REMOTE_SAMPLE_APP_IMAGE }}:v11"#g' build.gradle.kts
gradle jib -P javaVersion=11
java-main:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/python-sample-app-s3-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ jobs:
role-to-assume: arn:aws:iam::${{ env.ACCOUNT_ID }}:role/${{ secrets.E2E_TEST_ROLE_ARN }}
aws-region: ${{ matrix.aws-region }}



- name: Build Sample App Zip
working-directory: sample-apps/python
run: zip -r python-sample-app.zip .
Expand Down

0 comments on commit 9aac8e9

Please sign in to comment.