-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to exiftool 12.76 #394
Conversation
Upgrades the version of exiftool to 12.76, which is currently the most recent production release. Unfortunately, exiftool now appears to try to identify WordPerfect documents and does so badly. They come back as `image/x-wpg`. So, I updated `fits.xml` to exclude exiftool from running on `.wpd` and `.wp` extensions. Additionally, exiftool is now no longer reporting some metadata protected epubs. This is no big loss because other tools are able still able to get the info.
@pwinckles I'm getting the following error when I try to build this branch:
|
@dkinzer That looks like the mediainfo server rejecting the download. Not sure why. I can try to reproduce later. You might also try again on your side after letting some time pass. It might be a transient issue. |
Tried it one more time after lunch and this time it built without erroring out. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual inspection looks minimal and good.
Tests pass:
# The build only needs to be run once
docker build -f docker/Dockerfile-test -t fits-test .
docker run --rm -v `pwd`:/fits -v ~/.m2:/root/.m2 fits-test mvn clean test
>> [WARNING] Tests run: 120, Failures: 0, Errors: 0, Skipped: 21
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for FITS Parent 1.6.1-SNAPSHOT:
[INFO]
[INFO] FITS Parent ........................................ SUCCESS [ 3.093 s]
[INFO] FITS Tika .......................................... SUCCESS [ 14.481 s]
[INFO] FITS DROID ......................................... SUCCESS [ 11.142 s]
[INFO] FITS JHOVE ......................................... SUCCESS [ 3.731 s]
[INFO] FITS Tool Installer ................................ SUCCESS [01:24 min]
[INFO] FITS ............................................... SUCCESS [11:13 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:11 min
[INFO] Finished at: 2024-05-25T12:40:54-04:00
[INFO] ------------------------------------------------------------------------
@@ -15,7 +15,7 @@ | |||
<tool class="edu.harvard.hul.ois.fits.tools.jhove.Jhove" exclude-exts="dng,mbx,mbox,arw,adl,eml,java,doc,docx,docm,odt,rtf,pages,wpd,wp,epub,csv,avi,mov,mpg,mpeg,mkv,mp3,mp4,mpeg4,m2ts,mxf,ogv,mj2,divx,dv,m4v,m2v,ismv,pcd,zip" classpath-dirs="lib/jhove" /> | |||
<tool class="edu.harvard.hul.ois.fits.tools.embarc.EmbARC" include-exts="dpx" /> | |||
<tool class="edu.harvard.hul.ois.fits.tools.fileutility.FileUtility" exclude-exts="dng,wps,adl,jar,csv,m4a" classpath-dirs="lib/fileutility" /> | |||
<tool class="edu.harvard.hul.ois.fits.tools.exiftool.Exiftool" exclude-exts="wps,vsd,jar,avi,mov,mpg,mpeg,mkv,mp4,mxf,ogv,mj2,divx,dv,m4v,m2v,ismv,m2ts,mpeg4,rmvb,rm,wmv,vtt,adl" classpath-dirs="lib/exiftool" /> | |||
<tool class="edu.harvard.hul.ois.fits.tools.exiftool.Exiftool" exclude-exts="wps,wpd,wp,vsd,jar,avi,mov,mpg,mpeg,mkv,mp4,mxf,ogv,mj2,divx,dv,m4v,m2v,ismv,m2ts,mpeg4,rmvb,rm,wmv,vtt,adl" classpath-dirs="lib/exiftool" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skippping wpd
and wp
👍
Thanks, @pwinckles ! |
Upgrades the version of exiftool to 12.76, which is currently the most recent production release.
Unfortunately, exiftool now appears to try to identify WordPerfect documents and does so badly. They come back as
image/x-wpg
. So, I updatedfits.xml
to exclude exiftool from running on.wpd
and.wp
extensions.Additionally, exiftool is now no longer reporting some metadata protected epubs. This is no big loss because other tools are able still able to get the info.
This fixes the main build as the old version of exitool is no longer available on the exiftool website for some reason.
@awoods requesting a review (I can't tag reviewers on the side anymore as I no longer have perms).