-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event views #147
Event views #147
Conversation
shreyas-satish
commented
Nov 12, 2015
- Manage events, ticket types and participants for a proposal space.
- Added background job to import tickets from external ticket vendors (currently, there's only support for Explara).
- Make HTML badges (with QR Codes) for participants.
- Enable check-in process for participants.
- Serve API for basic contact exchange through zalebi.
- Added rq config.
Adding footable to ext_requires and UI changes for responsive participant table
company = forms.StringField(__("Company"), validators=[forms.validators.Length(max=80)]) | ||
job_title = forms.StringField(__("Job Title"), validators=[forms.validators.Length(max=80)]) | ||
twitter = forms.StringField(__("Twitter"), validators=[forms.validators.Length(max=15)]) | ||
events = QuerySelectMultipleField(__("Events"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need a model or query factory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the concerns in hasgeek/baseframe#112, I'd move this context into this file itself if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The events need to be scoped by the proposal space, which is why they're set in the view.
elif action == 'new-ticket-type': | ||
return url_for('new_ticket_type', profile=self.profile.name, space=self.name) | ||
elif action == 'new-ticket-client': | ||
return url_for('new_ticket_client', profile=self.profile.name, space=self.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we'll clean this up in hasgeek/coaster#77. :)
Eg: "ABC DEF EFG" -> ("ABC", "DEF EFG") | ||
""" | ||
name_splits = fullname.split() | ||
return name_splits[0], " ".join([s for s in name_splits[1:]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need a check for names that don't have a space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added check for null case. But, if a name doesn't have a space, this just returns an empty string for last name.
permission='event-edit') | ||
def ticket_type_edit(profile, space, ticket_type): | ||
form = TicketTypeForm(obj=ticket_type, model=TicketType) | ||
form.events.query = space.events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an __init__
method to the form that calls super
, then sets self.events.query = self.edit_obj.proposal_space.events
.
Removed logo from the header section.