Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HederaResponseCodes.sol up-to-date with the latest protobufs ones #847

Closed
natanasow opened this issue Jul 12, 2024 · 2 comments · Fixed by #1218
Closed

Make HederaResponseCodes.sol up-to-date with the latest protobufs ones #847

natanasow opened this issue Jul 12, 2024 · 2 comments · Fixed by #1218
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@natanasow
Copy link
Contributor

natanasow commented Jul 12, 2024

Problem

There are missing response codes in HederaResponseCodes.sol.

Solution

Update the HederaResponseCodes.sol contract with the protobufs ones defined here.

Add a consideration for an automated step that is run as part of release process to update this file

Alternatives

No response

@natanasow natanasow added the enhancement New feature or request label Jul 12, 2024
@natanasow natanasow changed the title Make HederaResponseCodes up-to-date with the latest protobufs ones Make HederaResponseCodes.sol up-to-date with the latest protobufs ones Jul 12, 2024
@Nana-EC
Copy link
Collaborator

Nana-EC commented Jul 12, 2024

Good idea.
We should explore is there's an automated approach here so it's easier to stay up to date.
That is can we take a protobuf file and create the solidity format for it?

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jan 24, 2025

@Ferparishuertas and @quiet-node added suggestions for a GA workflow that watched the protobuf repo and pulled in the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
2 participants