feat: Adds tests that verify IHRC904Proxy methods targeted to an EOA are functional when called by EOA #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng facades Signed-off-by: Simeon Nakov <[email protected]>
simzzz
requested review from
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
konstantinabl
requested changes
Jan 28, 2025
test/system-contracts/hedera-token-service/hrc-904/IHRC904Proxy.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/IHRC904Proxy.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
requested changes
Jan 29, 2025
contracts/system-contracts/hedera-token-service/examples/hrc-904/HRC904Contract.sol
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/IHRC904ProxyTests.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/IHRC904ProxyTests.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/IHRC904ProxyTests.js
Outdated
Show resolved
Hide resolved
quiet-node
reviewed
Jan 29, 2025
test/system-contracts/hedera-token-service/hrc-904/IHRC904ProxyTests.js
Outdated
Show resolved
Hide resolved
quiet-node
reviewed
Jan 29, 2025
test/system-contracts/hedera-token-service/hrc-904/IHRC904ProxyTests.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
reviewed
Jan 30, 2025
contracts/system-contracts/hedera-token-service/examples/hrc-904/HRC904Contract.sol
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/IHRC904ProxyTests.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <[email protected]>
konstantinabl
previously approved these changes
Feb 4, 2025
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds tests that verify IHRC904Proxy methods targeted to an EOA are functional when called by EOA
Related issue(s):
Closes #1147
Notes for reviewer:
Checklist