Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added test coverage of CancelAirdrop.sol #1192

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: added test coverage of CancelAirdrop.sol #1192

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
519d86e
feat: added test coverage of CancelAirdrop.sol
simzzz Jan 17, 2025
3edc3f6
feat: changes test suite string
simzzz Jan 20, 2025
ae54abb
feat: changed code comment
simzzz Jan 20, 2025
282d154
skipped tests temporarily
simzzz Jan 24, 2025
e553879
Merge branch 'main' into 1189-cancel-airdrop-coverage
simzzz Jan 27, 2025
c460142
feat: added test coverage of CancelAirdrop.sol
simzzz Jan 17, 2025
f00d8fc
revert removal of deploy functions
simzzz Jan 27, 2025
34f663a
exported magic string as constant
simzzz Jan 29, 2025
6e3785d
more clear comments for skipped tests
simzzz Jan 29, 2025
4dc5c46
requested changes from review
simzzz Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...stem-contracts/hedera-token-service/examples/hrc-904/CancelAirdrop.sol/CancelAirdrop.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...stem-contracts/hedera-token-service/examples/hrc-904/CancelAirdrop.sol/CancelAirdrop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"type": "int64[]"
}
],
"name": "cancelAirdrops",
"name": "cancelMultipleAirdrops",
"outputs": [
{
"internalType": "int64",
Expand Down
2 changes: 1 addition & 1 deletion contracts/system-contracts/hedera-token-service/examples/hrc-904/CancelAirdrop.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ contract CancelAirdrop is HederaTokenService {
// @param tokens Array of token addresses for the pending airdrops
// @param serials Array of serial numbers for NFT airdrops (use 0 for fungible tokens)
// @return responseCode The response code from the batch cancel operation (22 = success)
function cancelAirdrops(address[] memory senders, address[] memory receivers, address[] memory tokens, int64[] memory serials) public returns (int64 responseCode) {
function cancelMultipleAirdrops(address[] memory senders, address[] memory receivers, address[] memory tokens, int64[] memory serials) public returns (int64 responseCode) {
uint length = senders.length;
IHederaTokenService.PendingAirdrop[] memory pendingAirdrops = new IHederaTokenService.PendingAirdrop[](length);
for (uint i = 0; i < length; i++) {
Expand Down
12 changes: 12 additions & 0 deletions test/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,18 @@ const Contract = {
CancunOpcodes: 'CancunOpcodes',
KZGPointEvaluation: 'KZGPointEvaluation',
StateRegistry: 'StateRegistry',
Airdrop: 'Airdrop',
CancelAirdrop: 'CancelAirdrop',
AliasAccountUtility: 'AliasAccountUtility',
Airdrop: 'Airdrop',
CancelAirdrop: 'CancelAirdrop',
};

const CALL_EXCEPTION = 'CALL_EXCEPTION';
const CONTRACT_REVERT_EXECUTED_CODE = 3;
const GAS_LIMIT_1_000_000 = { gasLimit: 1_000_000 };
const GAS_LIMIT_2_000_000 = { gasLimit: 2_000_000 };
const GAS_LIMIT_5_000_000 = { gasLimit: 5_000_000 };
const GAS_LIMIT_10_000_000 = { gasLimit: 10_000_000 };
const GAS_LIMIT_800000 = { gasLimit: 800000 };
const GAS_LIMIT_8000000 = { gasLimit: 8000000 };
Expand All @@ -223,6 +229,8 @@ const HOUR = 60 * MINUTE;
const DAY = 24 * HOUR;
const WEEK = 7 * DAY;
const GWEI = 1e9;
const HTS_SYSTEM_CONTRACT_ADDRESS = '0.0.359';
const HAS_SYSTEM_CONTRACT_ADDRESS = '0.0.362';

module.exports = {
Events,
Expand All @@ -231,6 +239,8 @@ module.exports = {
CALL_EXCEPTION,
CONTRACT_REVERT_EXECUTED_CODE,
GAS_LIMIT_1_000_000,
GAS_LIMIT_2_000_000,
GAS_LIMIT_5_000_000,
GAS_LIMIT_10_000_000,
GAS_LIMIT_800000,
GAS_LIMIT_8000000,
Expand All @@ -245,4 +255,6 @@ module.exports = {
WEEK,
WEI,
GWEI,
HTS_SYSTEM_CONTRACT_ADDRESS,
HAS_SYSTEM_CONTRACT_ADDRESS,
};
Loading