Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend the coverage of account nonce discrepancies tests #703

Merged
merged 21 commits into from
Feb 6, 2025

Conversation

nickeynikolovv
Copy link
Contributor

@nickeynikolovv nickeynikolovv commented Mar 13, 2024

Description:

This PR extends the coverage of account nonce discrepancies tests according to test plan - https://www.notion.so/limechain/Address-account-nonce-discrepancies-Test-Plan-4a186e8cfabc49888ba501750f68d8de?pvs=4

Related issue(s):

Fixes #1016

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work but some comments

contracts/discrepancies/nonce/InternalCallee.sol Outdated Show resolved Hide resolved
contracts/discrepancies/nonce/InternalCallee.sol Outdated Show resolved Hide resolved
contracts/discrepancies/nonce/InternalCallee.sol Outdated Show resolved Hide resolved
contracts/discrepancies/nonce/InternalCallee.sol Outdated Show resolved Hide resolved
anastasiya-kovaliova and others added 6 commits March 25, 2024 16:08
Signed-off-by: Anastasia Kovaliova <[email protected]>
Signed-off-by: Anastasia Kovaliova <[email protected]>
- added and adapted internalTransfer function in internalCallee contract
- skipped the blocked tests due to some issues

Signed-off-by: Nikolay Nikolov <[email protected]>
- refactored some expected to fail function in test 030

Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv nickeynikolovv force-pushed the test_677-account-nonce-discrepancies-additional-tests branch from fa0b04c to 6c4a873 Compare March 25, 2024 14:17
Copy link

github-actions bot commented Mar 25, 2024

Test Results

 17 files  ± 0  103 suites  +2   25m 8s ⏱️ + 2m 20s
370 tests +20  351 ✅ +24  19 💤 ±0  0 ❌  - 4 
467 runs  +56  446 ✅ +59  21 💤 +1  0 ❌  - 4 

Results for commit 6671124. ± Comparison against base commit 7f00646.

This pull request removes 3 and adds 23 tests. Note that renamed tests count towards both.
"before all" hook for "should NOT be able to use transferFrom on fungible tokens without approval" ‑ TokenTransferContract Test Suite "before all" hook for "should NOT be able to use transferFrom on fungible tokens without approval"
"before all" hook for "should cancel a pending airdrop for a fungible token (FT)" ‑ HIP904 IHRC904Facade ContractTest Suite "before all" hook for "should cancel a pending airdrop for a fungible token (FT)"
"before each" hook for "Should check if an address is another address's operator" ‑ @OZERC1155Token Test Suite "before each" hook for "Should check if an address is another address's operator"
Should NOT allow a non-operator to transfer tokens to another account ‑ @OZERC1155Token Test Suite Should NOT allow a non-operator to transfer tokens to another account
Should NOT burn insufficient amount of token ‑ @OZERC1155Token Test Suite Should NOT burn insufficient amount of token
Should NOT transfer the ownership to another account if the caller is not owner ‑ @OZERC1155Token Test Suite Should NOT transfer the ownership to another account if the caller is not owner
Should allow an operator to transfer a token to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer a token to another account
Should allow an operator to transfer tokens in batch to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer tokens in batch to another account
Should burn token in batch ‑ @OZERC1155Token Test Suite Should burn token in batch
Should burn token ‑ @OZERC1155Token Test Suite Should burn token
Should check if an address is another address's operator ‑ @OZERC1155Token Test Suite Should check if an address is another address's operator
Should retrieve the token uri of a tokenID ‑ @OZERC1155Token Test Suite Should retrieve the token uri of a tokenID
Should set a new token URI ‑ @OZERC1155Token Test Suite Should set a new token URI
…

♻️ This comment has been updated with latest results.

quiet-node
quiet-node previously approved these changes Mar 26, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Great work thanks!

test/discrepancies/Nonce.js Outdated Show resolved Hide resolved
test/discrepancies/Nonce.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few comments to address.

contracts/discrepancies/nonce/ChainedContracts.sol Outdated Show resolved Hide resolved
test/hts-precompile/utils.js Outdated Show resolved Hide resolved
test/discrepancies/Nonce.js Outdated Show resolved Hide resolved
-added comments for additional info
-removed test 29

Signed-off-by: Nikolay Nikolov <[email protected]>
@Nana-EC
Copy link
Collaborator

Nana-EC commented Jun 20, 2024

@nickeynikolovv please rebase

@quiet-node
Copy link
Member

Hello @nickeynikolovv is this PR still relavant? If so please kindly update the PR. Thanks!

…nal-tests

# Conflicts:
#	test/constants.js
#	test/discrepancies/Nonce.js
#	test/system-contracts/hedera-token-service/utils.js
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow requested a review from a team as a code owner February 4, 2025 07:07
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow self-assigned this Feb 4, 2025
@natanasow natanasow added the enhancement New feature or request label Feb 4, 2025
@natanasow natanasow added this to the 0.12.0 milestone Feb 4, 2025
@natanasow natanasow changed the title test: Extend the coverage of account nonce discrepancies tests test: extend the coverage of account nonce discrepancies tests Feb 4, 2025
Nana-EC
Nana-EC previously approved these changes Feb 4, 2025
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additional scenarios.
Minor comment on test description but the additional coverage is great.
Thanks for following through - signing off to unblock

test/discrepancies/Nonce.js Outdated Show resolved Hide resolved
@natanasow natanasow merged commit 1feae23 into main Feb 6, 2025
36 checks passed
@natanasow natanasow deleted the test_677-account-nonce-discrepancies-additional-tests branch February 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish the implementation for PR #703 related to account nonce discrepancies
8 participants