-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: extend the coverage of account nonce discrepancies tests #703
test: extend the coverage of account nonce discrepancies tests #703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work but some comments
artifacts/contracts/discrepancies/nonce/ChainedContracts.sol/ChainedContracts.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Anastasia Kovaliova <[email protected]>
Signed-off-by: Anastasia Kovaliova <[email protected]>
Signed-off-by: Anastasia Kovaliova <[email protected]>
- added and adapted internalTransfer function in internalCallee contract - skipped the blocked tests due to some issues Signed-off-by: Nikolay Nikolov <[email protected]>
- refactored some expected to fail function in test 030 Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
fa0b04c
to
6c4a873
Compare
Test Results 17 files ± 0 103 suites +2 25m 8s ⏱️ + 2m 20s Results for commit 6671124. ± Comparison against base commit 7f00646. This pull request removes 3 and adds 23 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
This reverts commit 1697084.
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! Great work thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few comments to address.
-added comments for additional info -removed test 29 Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv please rebase |
Hello @nickeynikolovv is this PR still relavant? If so please kindly update the PR. Thanks! |
…nal-tests # Conflicts: # test/constants.js # test/discrepancies/Nonce.js # test/system-contracts/hedera-token-service/utils.js
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
…nal-tests # Conflicts: # test/constants.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additional scenarios.
Minor comment on test description but the additional coverage is great.
Thanks for following through - signing off to unblock
Signed-off-by: nikolay <[email protected]>
Description:
This PR extends the coverage of account nonce discrepancies tests according to test plan - https://www.notion.so/limechain/Address-account-nonce-discrepancies-Test-Plan-4a186e8cfabc49888ba501750f68d8de?pvs=4
Related issue(s):
Fixes #1016