Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve share modal UX #296

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Improve share modal UX #296

merged 4 commits into from
Aug 17, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Aug 16, 2023

Fixes an issue causing the draft URL to temporarily appear in the "Doc published" modal.

CleanShot.2023-08-16.at.14.27.28.mp4

If, somehow (I can't imagine how), the docNumber isn't available within 10 seconds, we'll just show the success modal without the share elements:
CleanShot 2023-08-16 at 14 29 18@2x

@jeffdaley jeffdaley marked this pull request as ready for review August 16, 2023 18:33
@jeffdaley jeffdaley requested a review from a team as a code owner August 16, 2023 18:33
@jeffdaley jeffdaley merged commit 3ff13d9 into main Aug 17, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/fix-url-flicker branch August 17, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants