Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RecentlyViewedDocs/Dashboard performance #318

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Improve RecentlyViewedDocs/Dashboard performance #318

merged 2 commits into from
Sep 1, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Sep 1, 2023 •
edited
Loading

Improves performance of the RecentlyViewedDocs service and Dashboard load times.

To test:

  1. Load the Hermes Dashboard
  2. Click to another route
  3. Return to the Dashboard
  4. Compare performance vs. main

@jeffdaley jeffdaley requested a review from a team as a code owner September 1, 2023 17:33
@jeffdaley jeffdaley added the enhancement New feature or request label Sep 1, 2023
@jeffdaley jeffdaley changed the title Improve RecentlyViewedDocs fetching Improve RecentlyViewedDocs fetching and Dashboard performance Sep 1, 2023
@jeffdaley jeffdaley changed the title Improve RecentlyViewedDocs fetching and Dashboard performance Improve RecentlyViewedDocs/Dashboard performance Sep 1, 2023
jfreda
jfreda approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jeffdaley jeffdaley merged commit 6d1bae1 into main Sep 1, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/investigate-dashboard-slowness branch September 1, 2023 20:21
@jeffdaley jeffdaley mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda