Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Update Button Organization pattern (bug bash) #2676

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Website: Update Button Organization pattern (bug bash) #2676

merged 4 commits into from
Feb 4, 2025
+16 −15

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Jan 29, 2025 •
edited
Loading

📌 Summary

PREVIEW

  • Clarifies some of the text around button alignment/order
  • Improved alt text for images
  • Combined 2 images of the modal + reading order into one

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Feb 4, 2025 2:54pm
hds-website ✅ Ready (Inspect) Visit Preview Feb 4, 2025 2:54pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jan 29, 2025
alex-ju
alex-ju previously approved these changes Jan 29, 2025
View reviewed changes
@shleewhite shleewhite changed the title Update alignment.md Website: Update Button Organization pattern (bug bash) Feb 3, 2025
@shleewhite shleewhite marked this pull request as ready for review February 3, 2025 20:38
@shleewhite shleewhite requested review from a team as code owners February 3, 2025 20:38
@shleewhite shleewhite requested a review from alex-ju February 3, 2025 20:38
jorytindall
jorytindall previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small non-blocking comment :shipit:

website/docs/patterns/button-organization/partials/guidelines/alignment.md Outdated Show resolved Hide resolved
dchyun
dchyun previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@dchyun dchyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Unrelated to your changes, but caught a couple missing periods in some lists in the Order and Grouping sections.

Screenshot 2025-02-04 at 9 04 26 AM Screenshot 2025-02-04 at 9 04 32 AM

@shleewhite shleewhite merged commit f106a57 into main Feb 4, 2025
10 checks passed
@shleewhite shleewhite deleted the fix/button-organization-docs branch February 4, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchyun dchyun dchyun approved these changes

@alex-ju alex-ju Awaiting requested review from alex-ju

@jorytindall jorytindall Awaiting requested review from jorytindall

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shleewhite @alex-ju @jorytindall @dchyun @hashibot-hds