-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website updates - Tag truncation #2694
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
I imagine this branch was split off of There are two possible scenarios now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine. I just noticed one issue in the anatomy tab and had some non-blocking suggstions to simplify the language.
I think we can keep this branch separate and merge it into |
0836996
to
8c400f8
Compare
Rebasing this branch off of the latest version of the @dchyun, perhaps you could help @majedelass with this? |
@KristinLBradley I think we decided to change the base to main so that merging the component updates doesn't merge these and put it on the website before release. |
Ok well if this branch was created from the dchyun/tag-text-truncation branch you'll still need to rebase off of the latest code from it and fix the conflicts so that this branch reflects the actual intended changes. Although you could wait until the parent branch is merged into |
The base branch was changed.
Co-authored-by: Heather Larsen <[email protected]> Co-authored-by: Kristin Bradley <[email protected]>
Co-authored-by: Lee White <[email protected]>
Co-authored-by: Kristin Bradley <[email protected]> Co-authored-by: Alex <[email protected]>
6e2e1d9
to
4c79f1e
Compare
π Summary
If merged, this PR will update the guidelines and code tabs of the Helio website.
π οΈ Detailed description
This is necessary for the truncation changes applied to the tag component.
π External links
Jira ticket: HDS-4505
Figma file: File
π¬ Please consider using conventional comments when reviewing this PR.