Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website updates - Tag truncation #2694

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Website updates - Tag truncation #2694

wants to merge 12 commits into from

Conversation

majedelass
Copy link
Contributor

@majedelass majedelass commented Feb 10, 2025

πŸ“Œ Summary

If merged, this PR will update the guidelines and code tabs of the Helio website.

πŸ› οΈ Detailed description

This is necessary for the truncation changes applied to the tag component.

πŸ”— External links

Jira ticket: HDS-4505
Figma file: File


πŸ’¬ Please consider using conventional comments when reviewing this PR.

@majedelass majedelass requested review from a team as code owners February 10, 2025 21:39
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Feb 19, 2025 9:39pm
hds-website βœ… Ready (Inspect) Visit Preview Feb 19, 2025 9:39pm

@majedelass
Copy link
Contributor Author

@dchyun it seems as though I may have ported in your work when I changed branches. Is there a way to remove them? @alex-ju maybe this is a task for you?

@alex-ju
Copy link
Member

alex-ju commented Feb 11, 2025

@dchyun it seems as though I may have ported in your work when I changed branches. Is there a way to remove them? @alex-ju maybe this is a task for you?

I imagine this branch was split off of dchyun/tag-text-truncation so I just changed its base to reflect that.

There are two possible scenarios now:

  • this work gets reviewed/approved/merged into Dylan's branch, then that one gets merged to main
  • Dylan's branch gets merged to main sooner than this one, in which case this branch will automatically update its base to be main

Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine. I just noticed one issue in the anatomy tab and had some non-blocking suggstions to simplify the language.

@dchyun
Copy link
Contributor

dchyun commented Feb 11, 2025

@dchyun it seems as though I may have ported in your work when I changed branches. Is there a way to remove them? @alex-ju maybe this is a task for you?

I imagine this branch was split off of dchyun/tag-text-truncation so I just changed its base to reflect that.

There are two possible scenarios now:

  • this work gets reviewed/approved/merged into Dylan's branch, then that one gets merged to main
  • Dylan's branch gets merged to main sooner than this one, in which case this branch will automatically update its base to be main

I think we can keep this branch separate and merge it into main separately. It can be held back from merging into main until the release occurs with the tag changes.

zamoore
zamoore previously approved these changes Feb 14, 2025
@KristinLBradley
Copy link
Contributor

Rebasing this branch off of the latest version of the dchyun/tag-text-truncation should get rid of the unrelated file diffs. You will need to fix conflicts as well.

@dchyun, perhaps you could help @majedelass with this?

@majedelass
Copy link
Contributor Author

@KristinLBradley I think we decided to change the base to main so that merging the component updates doesn't merge these and put it on the website before release.

@KristinLBradley
Copy link
Contributor

KristinLBradley commented Feb 18, 2025

@KristinLBradley I think we decided to change the base to main so that merging the component updates doesn't merge these and put it on the website before release.

Ok well if this branch was created from the dchyun/tag-text-truncation branch you'll still need to rebase off of the latest code from it and fix the conflicts so that this branch reflects the actual intended changes. Although you could wait until the parent branch is merged into main (if that's going to be soon) and then rebase off of main. (Once the parent branch is merged the base for this branch will automatically change to main.)

Base automatically changed from dchyun/tag-text-truncation to main February 19, 2025 14:33
@dchyun dchyun dismissed stale reviews from LilithJames-HDS, zamoore, and alex-ju February 19, 2025 14:33

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants