Skip to content

Commit

Permalink
Version bump playwright and NPM (#2585)
Browse files Browse the repository at this point in the history
* Update playwright version to fix e2e runner

An outdated version of playwright had dependencies that were no longer
present in the package repositories for ubuntu@latest (noble).
Downgrading to ubuntu 22.04 temporarily to see if playwright would
install on 22.04 confirmed this.

The solution ended up being to upgrade playwright so that we can
continue to use ubuntu@latest

* Update npm to latest
  • Loading branch information
rmainwork authored Oct 15, 2024
1 parent dc75081 commit 076ad0f
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 18 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 20
- name: Install npm@8
run: npm install --global npm@8
- name: Install npm@latest
run: npm install --global npm@latest
- name: Install dependencies
run: npm ci
- name: Install Playwright
Expand Down
31 changes: 16 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@hashicorp/platform-tools": "^0.10.0",
"@hashicorp/platform-types": "^0.4.0",
"@octokit/rest": "^19.0.5",
"@playwright/test": "^1.28.0",
"@playwright/test": "^1.48.0",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.1",
"@testing-library/user-event": "^14.4.3",
Expand Down

0 comments on commit 076ad0f

Please sign in to comment.