Print panic output on Error log level #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@tomhjp Would you mind giving this PR a review? |
|
Anything I can help with to get a review going? |
|
@VioletHynes Would your team have some bandwidth to review this one? |
|
Hi there -- this isn't my team's area but I'll try and forward this to the team that owns this. Thanks :) |
|
Thanks, appreciate it! |
robmonte
reviewed
Oct 17, 2024
Co-authored-by: Robert <[email protected]>
|
@robmonte Gentle reminder to review the PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for creating this awesome library! We at Mattermost use it a lot.
If a plugin panics, the panic message goes to stderr of the plugin. Because the log lines don't have any levelled prefix like
[ERROR], the panic message would end up in the Debug level. That makes it hard to spot, why a plugin panicked.The (hacky) solution is to check if any unparsed lines start with
panic:. If that is the case, this line and all unparsed following lines go to the Error level. Most likely, these will be the last log lines anyway before the process dies.I tried adding a test to cover, but that would require spinning up another process (that then panics) to cover this PR.