Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Add generic functions #313

Merged
merged 3 commits into from
Jan 4, 2024
Merged

🛠️ Add generic functions #313

merged 3 commits into from
Jan 4, 2024

Conversation

arybolovlev
Copy link
Contributor

Description

This PR introduces two new generic functions needToAddFinalizer and isDeletionCandidate that aim to replace respectful methods NeedToAddFinalizer and IsDeletionCandidate of all existing Kinds.

Usage Example

N/A.

Release Note

Release note for CHANGELOG:

NONE

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added api controller documentation Improvements or additions to documentation golang size/M labels Dec 27, 2023
@github-actions github-actions bot added the test label Dec 27, 2023
@arybolovlev arybolovlev marked this pull request as ready for review December 27, 2023 09:41
@arybolovlev arybolovlev requested a review from a team as a code owner December 27, 2023 09:41
@arybolovlev arybolovlev merged commit 3d35888 into main Jan 4, 2024
6 checks passed
@arybolovlev arybolovlev deleted the add-generic-functions branch January 4, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhouston jrhouston jrhouston approved these changes

Assignees
No one assigned
Labels
api controller documentation Improvements or additions to documentation golang size/M test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arybolovlev @jrhouston