Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec2: oom_score_adj support #40

Merged
merged 14 commits into from
Jun 17, 2024
Merged

exec2: oom_score_adj support #40

merged 14 commits into from
Jun 17, 2024

Conversation

pkazmierczak
Copy link
Contributor

This implements support for setting oom_score_adj on a per-task basis.

See hashicorp/nomad#11087 and hashicorp/nomad#23259 for context.

@pkazmierczak pkazmierczak marked this pull request as ready for review June 13, 2024 16:52
@pkazmierczak pkazmierczak requested a review from a team as a code owner June 13, 2024 16:52
@pkazmierczak pkazmierczak requested review from shoenig and tgross and removed request for a team June 13, 2024 16:53
@pkazmierczak pkazmierczak self-assigned this Jun 13, 2024
shoenig
shoenig reviewed Jun 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@shoenig
Copy link
Contributor

shoenig commented Jun 13, 2024 •
edited
Loading

I think we can add a test for this in either driver_test.go or in the e2e suite. The cgroup mem/cpu value test(s) should be good examples.

@pkazmierczak pkazmierczak requested a review from shoenig June 14, 2024 14:48
@pkazmierczak pkazmierczak mentioned this pull request Jun 14, 2024
Merged
shoenig
shoenig approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just the one leftover comment I think

plugin/driver.go Outdated Show resolved Hide resolved
@pkazmierczak pkazmierczak merged commit 9978506 into main Jun 17, 2024
10 checks passed
@pkazmierczak pkazmierczak deleted the f-oom-score-adj-exec2 branch June 17, 2024 13:17
@pkazmierczak pkazmierczak mentioned this pull request Jun 17, 2024
Closed
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoenig shoenig shoenig approved these changes

@tgross tgross Awaiting requested review from tgross

Assignees

@pkazmierczak pkazmierczak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkazmierczak @shoenig