notes

nomad/structs/structs.go

@@ -11115,6 +11115,7 @@ type Allocation struct {
 	AllocatedResources *AllocatedResources
 
 	// VolumeID is the ID of the host volume that this allocation requires.
+	// FIXME:could be multiple, could be CSI? can't just be a string
 	VolumeID *string
 
 	// Metrics associated with this allocation

scheduler/feasible.go

@@ -161,6 +161,8 @@ func (h *HostVolumeChecker) SetVolumes(allocName string, volumes map[string]*str
 			continue
 		}
 
+		// FIXME: if there's a sticky vol set, adjust this to look for an ID
+
 		if req.PerAlloc {
 			// provide a unique volume source per allocation
 			copied := req.Copy()

scheduler/generic_sched.go

@@ -894,11 +894,14 @@ func updateRescheduleTracker(alloc *structs.Allocation, prev *structs.Allocation
 
 // findPreferredNode finds the preferred node for an allocation
 func (s *GenericScheduler) findPreferredNode(place placementResult) (*structs.Node, error) {
+	// TODO: is previous allocation set on destrouctive updates?
 	prev := place.PreviousAllocation()
 	if prev == nil {
 		return nil, nil
 	}
 	if place.TaskGroup().EphemeralDisk.Sticky || place.TaskGroup().EphemeralDisk.Migrate {
+		// TODO: this could be a good place where we'd stick the sticky volume
+		// logic, to find the node that must have the right vol id
 		var preferredNode *structs.Node
 		ws := memdb.NewWatchSet()
 		preferredNode, err := s.state.NodeByID(ws, prev.NodeID)