review comments

hashicorp · Jun 10, 2024 · ebebda4 · ebebda4
1 parent 30e78db
commit ebebda4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/.changelog/23259.txt b/.changelog/23259.txt
diff --git a/nomad/structs/structs.go b/nomad/structs/structs.go
@@ -2498,7 +2498,7 @@ func (r *Resources) Validate() error {
 	}
 
 	if r.OOMScoreAdj < 0 {
-		mErr.Errors = append(mErr.Errors, fmt.Errorf("OOMScoreAdj value (%d) must be a positive integer", r.OOMScoreAdj))
+		mErr.Errors = append(mErr.Errors, fmt.Errorf("OOMScoreAdj value (%d) must not be negative", r.OOMScoreAdj))
 	}
 
 	return mErr.ErrorOrNil()

diff --git a/nomad/structs/structs_test.go b/nomad/structs/structs_test.go
@@ -2229,7 +2229,7 @@ func TestTask_Validate_Resources(t *testing.T) {
 			res: &Resources{
 				OOMScoreAdj: -3,
 			},
-			err: "OOMScoreAdj value (-3) must be a positive integer",
+			err: "OOMScoreAdj value (-3) must not be negative",
 		},
 	}