[server] Directed leadership transfer CLI and API #17383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
added
type/enhancement
theme/cli
theme/api
angrycub
force-pushed
the
f-leader-transfer
branch
from
83094c5 to
8f00c63
Compare
angrycub
force-pushed
the
f-leader-transfer
branch
from
8de8007 to
597e034
Compare
|
Thank you for this! Was looking for this command and excited to see this PR. |
I think this makes the validations a little easier to parse as a reader and eliminates nesting
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
angrycub
force-pushed
the
f-leader-transfer
branch
from
597e034 to
c5ded91
Compare
angrycub
force-pushed
the
f-leader-transfer
branch
from
c5ded91 to
a557c7d
Compare
tgross
approved these changes
Oct 4, 2023
Comment on lines
+150
to
+151
| <Tabs> | ||
| <Tab heading="Nomad CLI"> |
There was a problem hiding this comment.
Leave this for now, but adding a brand new way to demonstrate API examples is the sort of thing that really doesn't belong in a feature PR. We end up with a bunch of one-off decisions that way that aren't applied equally across the API docs. In the future, if you want to do this sort of thing, make a separate PR for it so that we can discuss it independently of critical feature work.
Comment on lines
+159
to
+190
| for i := 0; i < retryCount; i++ { | ||
| err := s.raft.LeadershipTransferToServer(to.ID, to.Address).Error() | ||
| if err == nil { | ||
| s.logger.Info("successfully transferred leadership") | ||
| return nil | ||
| } | ||
|
|
||
| // "cannot transfer leadership to itself" | ||
| // Handled at top of function, but reapplied here to prevent retrying if | ||
| // it occurs while we are retrying | ||
| if err.Error() == "cannot transfer leadership to itself" { | ||
| s.logger.Debug("leadership transfer to current leader is a no-op") | ||
| return nil | ||
| } | ||
|
|
||
| // ErrRaftShutdown: Don't retry if raft is shut down. | ||
| if err == raft.ErrRaftShutdown { | ||
| return err | ||
| } | ||
|
|
||
| // ErrUnsupportedProtocol: Don't retry if the Raft version doesn't | ||
| // support leadership transfer since this will never succeed. | ||
| if err == raft.ErrUnsupportedProtocol { | ||
| return fmt.Errorf("leadership transfer not supported with Raft version lower than 3") | ||
| } | ||
|
|
||
| // ErrEnqueueTimeout: This seems to be the valid time to retry. | ||
| s.logger.Error("failed to transfer leadership attempt, will retry", | ||
| "attempt", i, | ||
| "retry_limit", retryCount, | ||
| "error", err, | ||
| ) |
Co-authored-by: Tim Gross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API endpoint and a CLI command to allow cluster operators to move leadership from the current leader to a specified server node. This can reduce leadership churn during rolling updates by allowing the operator to migrate leadership to the first upgraded node.
Commits
Fixes: #7376