[ui] Bugfix: Wrap the passed path prop as a handlebars tag #18598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
f-ui/bugfix-no-variable-write-job-variables-link
branch
from
1dd0495 to
d50f0fb
Compare
Ember Test Audit comparison
|
lgfa29
approved these changes
Oct 3, 2023
philrenaud
deleted the
f-ui/bugfix-no-variable-write-job-variables-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the new /job/:jobid/variables page, we list variables that can be automatically read by the job in question.
In the event that the user does not have
write variableaccess, we want to provide the name of the path, not as a link, so it can at least be known to them.Without the wrapping
{{}}brackets, this would always output the string "@path", instead of the desired passed path string.