Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: get Consul token from hook resources #18600

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tgross
Copy link
Member

@tgross tgross commented Sep 27, 2023

When Workload Identity is being used with Consul, the consul_hook will add Consul tokens to the alloc hook resources. Update the group_service_hook and service_hook to use those tokens when available for registering and deregistering Consul workloads.

@github-actions
Copy link

Ember Test Audit comparison

f-consul-wi-real-consul_hook 1358e25 change
passes 1506 1532 +26
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

When Workload Identity is being used with Consul, the `consul_hook` will add
Consul tokens to the alloc hook resources. Update the `group_service_hook` and
`service_hook` to use those tokens when available for registering and
deregistering Consul workloads.
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit fb7582d into main Oct 4, 2023
21 checks passed
@tgross tgross deleted the f-consul-wi-service-hooks branch October 4, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants