[ui] Access Control CRUD: Make name fields for Policies and Roles required #18605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
f-ui/access-control-required-inputs
branch
from
148b38b to
145405e
Compare
Ember Test Audit comparison
|
philrenaud
added a commit
that referenced
this pull request
Sep 29, 2023
lhaig
added a commit
to lhaig/nomad
that referenced
this pull request
Dec 28, 2024
…cies and Roles required (hashicorp#18605) (hashicorp#18626)" This reverts commit 8d717ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new Helios form input required attr
This component is a little more involved than our older input component, so we have to explicitly set an updateRoleName / updatePolicyName method rather than it just implicitly knowing what to do. But the benefit is consistency with the rest of our form styles so a worthwhile tradeoff.
This PR also cleans up a bit of the old policy-specific styles and moves them into the larger access-control style section.