Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump setup-golang and fix workflow yaml extensions #19568

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Jan 2, 2024

Bumps our hashicorp/setup-golang to v2, which itself bumps the official cache and setup-go actions.

Also fixes the file extension of some of our workflows/ files to use .yaml which is technically correct

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places that are using .yml that need to be updated as well:

gh workflow run build.yml --ref ${{ github.ref_name }} --field build-ref=${{ steps.commit-change-push.outputs.build-ref }} --field make-prerelease=false

The Nomad Enterprise repo may have additional ones for the CE->ENT flow, and the release checklist as well 😅

@shoenig
Copy link
Contributor Author

shoenig commented Jan 2, 2024

Hah. Uhh let me just backout the yaml changes; they're beside the point.

Copy link

github-actions bot commented Jan 2, 2024

Ember Test Audit comparison

main cc34b218d1eb88bedf4052c15e743e171d1401be change
passes 1540 1540 0
failures 0 0 0
flaky 0 0 0
duration 10m 52s 480ms 10m 54s 958ms +02s 478ms

@shoenig shoenig force-pushed the bump-setup-golang branch from cc34b21 to 8964a64 Compare January 2, 2024 15:13
@shoenig shoenig merged commit 23e5ffb into main Jan 2, 2024
19 checks passed
@shoenig shoenig deleted the bump-setup-golang branch January 2, 2024 15:41
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants