Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Squashing Ember deprecations #22424

Merged
merged 2 commits into from
Jun 19, 2024
Merged

[ui] Squashing Ember deprecations #22424

merged 2 commits into from
Jun 19, 2024

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented May 30, 2024

Getting pretty tired of these party-poopers:
image

Note: a few of the other deprecation warnings are such that an upgrade to Ember 4+ is warranted if we want them to go away badly enough. This gets rid of the noisiest one (without having to mess with our deprecation-workflow.js file)

Copy link

github-actions bot commented May 30, 2024

Ember Test Audit comparison

main 270f167 change
passes 1564 1572 +8
failures 0 0 0
flaky 0 0 0
duration 11m 28s 571ms 11m 26s 721ms -01s 850ms

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philrenaud philrenaud merged commit 81d4f36 into main Jun 19, 2024
15 checks passed
@philrenaud philrenaud deleted the b-ui/deprecation-squashing branch June 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants