raw_exec: oom_score_adj support #23308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
force-pushed
the
f-oom-score-adj-rawexec
branch
from
6ac2202 to
1410f8f
Compare
pkazmierczak
added
backport/ent/1.8.x+ent
tgross
approved these changes
Jun 13, 2024
Comment on lines
+53
to
+54
| - `oom_score_adj` - (Optional) A positive integer to indicate the likelihood of | ||
| the task being OOM killed (valid only for Linux). Defaults to 0. |
There was a problem hiding this comment.
I missed this on the Docker PR, but we don't actually enforce that it's positive in the driver code, right?
There was a problem hiding this comment.
Right! And also there's a mistake both here and in the docker driver docs: I fix.oom_score_adj is not set in the driver options, but as a task config option.
shoenig
approved these changes
Jun 13, 2024
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #23259 and #11087 for context.