Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Dont show keyboard hints when a user is trying to take a screenshot into release/1.8.x #23378

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #23365 to be assessed for backporting due to the inclusion of the label backport/1.8.x.

The below text is copied from the body of the original PR.


Resolves #23361

How to test

  • Buy a macbook (or pretend)
  • Hold down shift, to see hints. Release and they're gone!
  • Hold down cmd+shift+4 to take a screenshot
  • Note that in holding the command key, the shift key no longer triggers the display of keyboard hints.

Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/23361-nomad-webui-should-detect-if-modifiers-in-addition-to-shift-are-being-pressed-and-hide-the-shortcuts/briefly-select-egret branch from 69351b5 to 7ce7d69 Compare June 18, 2024 16:37
Copy link

Ember Test Audit comparison

release/1.8.x 7ce7d69 change
passes 1563 1563 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud merged commit 038a94e into release/1.8.x Jun 20, 2024
15 of 16 checks passed
@philrenaud philrenaud deleted the backport/23361-nomad-webui-should-detect-if-modifiers-in-addition-to-shift-are-being-pressed-and-hide-the-shortcuts/briefly-select-egret branch June 20, 2024 19:56
Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants