Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/jobspec: Fix "task" block placement #23406

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

heitorPB
Copy link
Contributor

The task block should be inside the group block. The example in the page places the task block directly under job.

The `task` block should be inside the `group` block. The example in the
page places the `task` block directly under `job`.
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@heitorPB
Copy link
Contributor Author

Is it really necessary to sign a CLA for such a minor change?

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heitorPB!

Is it really necessary to sign a CLA for such a minor change?

Technically, yes we're supposed to require it for everything, but no one is going to complain if I just go ahead and merge this minor fix. 😀

@tgross tgross added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line labels Jun 21, 2024
@tgross tgross merged commit 0588172 into hashicorp:main Jun 21, 2024
9 of 11 checks passed
Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line
Projects
Development

Successfully merging this pull request may close these issues.

2 participants