Backport of [ui] Pack metadata booleanified and added to the statuses endpoint into release/1.8.x #23644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/f-ui/pack-meta-on-statuses/formerly-brave-beetle
branch
from
24c512b to
8446885
Compare
Ember Test Audit comparison
|
philrenaud
deleted the
backport/f-ui/pack-meta-on-statuses/formerly-brave-beetle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23404 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
The below text is copied from the body of the original PR.
Context: Way back in Two-ought-twenty-two, we added a visual indicator for whether a job was run via Nomad Pack in the UI. We could do this because the /jobs endpoint returns job meta information, and pack consistently puts
meta.pack.nameetc. such that we can detect it.With the purpose-built /statuses endpoint, we can be choosy about what we want to include and by default weren't delving into job metadata.
This PR checks to see if any of the tell-tale signs of pack are present, and if so, presents an
isPackboolean to the endpoint that the UI turns into a little badge:Overview of commits