helper: sanitize method on ACL token object #24600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several places where we want to redact the secret ID of an ACL token, some of which are in the Enterprise code base for Sentinel. Add a new method `Sanitize` that mirrors the one we have on `Node`. Ref: hashicorp/nomad-enterprise#2087
schmichael
approved these changes
Dec 3, 2024
| } | ||
|
|
||
| out := a.Copy() | ||
| out.SecretID = "" |
There was a problem hiding this comment.
Why not "<redacted>"? I think Node only does "" because there's no reason for humans to even need to know that field exists. It's an internal implementation detail.
I'm fine with ACLToken going either way, and I suppose there's something to be said for consistency.
There was a problem hiding this comment.
I didn't want to change the format of the objects we're emitting in the event stream (at least not without thinking about that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where we want to redact the secret ID of an ACL token, some of which are in the Enterprise code base for Sentinel. Add a new method
Sanitizethat mirrors the one we have onNode.This changeset doesn't change any existing behavior, just makes it easier to reuse.
Ref: https://github.com/hashicorp/nomad-enterprise/pull/2087