sentinel: remove default scope for Sentinel apply command #24601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
added
type/enhancement
theme/enterprise
schmichael
approved these changes
Dec 3, 2024
tgross
force-pushed
the
sentinel-no-default-scope
branch
from
0700a8e to
8e35e69
Compare
tgross
force-pushed
the
dynamic-host-volumes
branch
from
bef9714 to
8c3d8fe
Compare
When we add a Sentinel scope for dynamic host volumes, having a default `-scope` value for `sentinel apply` risks accidentally adding policies for volumes to the job scope. This would immediately prevent any job from being submitted. Forcing the administrator to pass a `-scope` will prevent accidental misuse. Ref: hashicorp/nomad-enterprise#2087 Ref: #24479
tgross
force-pushed
the
sentinel-no-default-scope
branch
from
8e35e69 to
2d8540c
Compare
tgross
added a commit
that referenced
this pull request
Dec 9, 2024
When we add a Sentinel scope for dynamic host volumes, having a default `-scope` value for `sentinel apply` risks accidentally adding policies for volumes to the job scope. This would immediately prevent any job from being submitted. Forcing the administrator to pass a `-scope` will prevent accidental misuse. Ref: hashicorp/nomad-enterprise#2087 Ref: #24479
tgross
added a commit
that referenced
this pull request
Dec 13, 2024
When we add a Sentinel scope for dynamic host volumes, having a default `-scope` value for `sentinel apply` risks accidentally adding policies for volumes to the job scope. This would immediately prevent any job from being submitted. Forcing the administrator to pass a `-scope` will prevent accidental misuse. Ref: hashicorp/nomad-enterprise#2087 Ref: #24479
tgross
added a commit
that referenced
this pull request
Dec 19, 2024
When we add a Sentinel scope for dynamic host volumes, having a default `-scope` value for `sentinel apply` risks accidentally adding policies for volumes to the job scope. This would immediately prevent any job from being submitted. Forcing the administrator to pass a `-scope` will prevent accidental misuse. Ref: hashicorp/nomad-enterprise#2087 Ref: #24479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add a Sentinel scope for dynamic host volumes, having a default
-scopevalue forsentinel applyrisks accidentally adding policies for volumes to the job scope. This would immediately prevent any job from being submitted. Forcing the administrator to pass a-scopewill prevent accidental misuse.Ref: https://github.com/hashicorp/nomad-enterprise/pull/2087
Ref: #24479